Add onFailure property to ignore failures #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I39da458b104b405fb532f19dc5eb776435b582e5
Change-Id: Ic5164b6f11c4f2dfbbcf2fc0fdf4ab384c1ffcab
Change-Id: I7eba60104e1610e62915787b01691b2a5940fc0a
Change-Id: I5644725eececa3cf9380f47100914bd1b7829918
Change-Id: I977c07b86290185252bfb7f2d411504bb31e5d6c
Change-Id: Ia50eb033b5a87cddcb05e451711c1fd20d5366d1
Change-Id: Ifbd98ceb330ceed47a01cc560bf40885bc16b443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an on cluster deployment, there are situations when a health check is expected to fail. We want to give the option to keep those in configuration, but ignore them for the purposes of the aggregate healthcheck reporting.
Specifying
onFailure: ignorewill now run a health check, but not report as a failure tohealthchecks.validator.gdc.gke.io/defaultCRD.